chizui/Il2CppInspectorRedux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clean up TODOs

Browse Source
This commit is contained in:
Katy Coe
2019-11-02 18:48:44 +01:00
parent 509b0cb778
commit 614f5c0e01
3 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Il2CppInspector/FileFormatReaders/MachOReader.cs
View File

@@ -140,7 +140,7 @@ namespace Il2CppInspector
foreach (var section in sections) { foreach (var section in sections) {
var rels = ReadArray<MachO_relocation_info>(section.ImageRelocOffset, section.NumRelocEntries); var rels = ReadArray<MachO_relocation_info>(section.ImageRelocOffset, section.NumRelocEntries);
// TODO: Implement // TODO: Implement Mach-O relocations
if (rels.Any()) { if (rels.Any()) {
Console.WriteLine("Mach-O file contains relocations (feature not yet implemented)"); Console.WriteLine("Mach-O file contains relocations (feature not yet implemented)");
break; break;

2
Il2CppInspector/Reflection/MethodBase.cs
View File

@@ -66,7 +66,7 @@ namespace Il2CppInspector.Reflection
// Generic method definition? // Generic method definition?
if (Definition.genericContainerIndex >= 0) { if (Definition.genericContainerIndex >= 0) {
IsGenericMethod = true; IsGenericMethod = true;
IsGenericMethodDefinition = true; // TODO: Only if all of the parameters are unresolved generic type parameters IsGenericMethodDefinition = true;
ContainsGenericParameters = true; ContainsGenericParameters = true;
// Store the generic type parameters for later instantiation // Store the generic type parameters for later instantiation

6
Il2CppInspector/Reflection/TypeInfo.cs
View File

@@ -109,8 +109,6 @@ namespace Il2CppInspector.Reflection {
+ (GenericTypeArguments != null ? "[" + string.Join(",", GenericTypeArguments.Select(x => x.FullName ?? x.Name)) + "]" : "") + (GenericTypeArguments != null ? "[" + string.Join(",", GenericTypeArguments.Select(x => x.FullName ?? x.Name)) + "]" : "")
+ (IsArray? "[]" : ""); + (IsArray? "[]" : "");
// TODO: Alot of other generics stuff
public List<TypeInfo> GenericTypeParameters { get; } public List<TypeInfo> GenericTypeParameters { get; }
public List<TypeInfo> GenericTypeArguments { get; } public List<TypeInfo> GenericTypeArguments { get; }
@@ -168,8 +166,6 @@ namespace Il2CppInspector.Reflection {
public Array GetEnumValues() => IsEnum? DeclaredFields.Where(x => x.Name != "value__").Select(x => x.DefaultValue).ToArray() : throw new InvalidOperationException("Type is not an enumeration"); public Array GetEnumValues() => IsEnum? DeclaredFields.Where(x => x.Name != "value__").Select(x => x.DefaultValue).ToArray() : throw new InvalidOperationException("Type is not an enumeration");
// TODO: Generic stuff
// Initialize from specified type index in metadata // Initialize from specified type index in metadata
// Top-level types // Top-level types
@@ -195,7 +191,7 @@ namespace Il2CppInspector.Reflection {
if (Definition.genericContainerIndex >= 0) { if (Definition.genericContainerIndex >= 0) {
IsGenericType = true; IsGenericType = true;
IsGenericParameter = false; IsGenericParameter = false;
IsGenericTypeDefinition = true; // TODO: Only if all of the parameters are unresolved generic type parameters IsGenericTypeDefinition = true; // All of our generic type parameters are unresolved
ContainsGenericParameters = true; ContainsGenericParameters = true;
// Store the generic type parameters for later instantiation // Store the generic type parameters for later instantiation